search

unovue / shadcn-vue

Vue port of shadcn-ui
https://www.shadcn-vue.com/
MIT License
4.89k stars 280 forks source link

[Feature]: Command #7

Closed zernonia closed 1 year ago

zernonia commented 1 year ago

Describe the feature

https://ui.shadcn.com/docs/components/command

Realized it requires cmdk component. We could use https://github.com/xiaoluoboding/vue-command-palette

Additional information

wasimTQ commented 1 year ago

@zernonia I'd like to start from here

zernonia commented 1 year ago

@wasimTQ sure! I'm not sure how extensive, and easy to style vue-command-pallete. You may give it a try. But I would most likely leaning into developing Combobox in Radix Vue

wasimTQ commented 1 year ago

Sure. I'll give it a try. I was planning to work on this or the theming. But I hope this will be a pretty good challenge for me

wasimTQ commented 1 year ago

Then I'll start off with Combobox first. Thank you for the suggestion

wasimTQ commented 1 year ago

@zernonia Are you working on this atm?

zernonia commented 1 year ago

@wasimTQ not yet.. but was about to 😂 maybe you can help with the theming?

wasimTQ commented 1 year ago

Sure. But I think it's a bit too much for me to start my first contribution. I'll give it a shot. If you find anything more beginner friendly, please share it with me

k11q commented 1 year ago

I found the command component has some accessibility issues. I dont think you need command component for it, you essentially need a searchbox/autocomplete for it,

Maybe these can serve as reference aswell https://ariakit.org/components/combobox https://ariakit.org/examples/combobox-multiple

zernonia commented 1 year ago

Yup @khairulhaaziq ! that's why I mentioned the combobox ticket above in my comment 😁