unovue / shadcn-vue

Vue port of shadcn-ui
https://www.shadcn-vue.com/
MIT License
4.59k stars 267 forks source link

doc: Update Tags with Combobox example to make conent collapsable #723

Closed NehemiahAklil closed 1 month ago

NehemiahAklil commented 1 month ago

๐Ÿ”— Linked issue

โ“ Type of change

๐Ÿ“š Description

Tags with Combobox example on the documentation isn't in accordance to the Combobox documentation of radix-vue which wraps the Combobox content inside ComboboxContent before wrapping in ComboboxPortal component which makes it collapsible as the demo below. check the current docs and you will see once it pops down the list of options there is no option to dismiss the options. Here is the anatomy of Combobox the current commit follows as the radix-vue documentation instructs.

<template>
  <ComboboxRoot>
    <ComboboxAnchor>
      <ComboboxInput />
      <ComboboxTrigger />
      <ComboboxCancel />
    </ComboboxAnchor>

    <ComboboxPortal>
      <ComboboxContent>
        <ComboboxViewport>
          <ComboboxEmpty />

          <ComboboxItem>
            <ComboboxItemIndicator />
          </ComboboxItem>

          <ComboboxGroup>
            <ComboboxLabel />
            <ComboboxItem>
              <ComboboxItemIndicator />
            </ComboboxItem>
          </ComboboxGroup>
          <ComboboxSeparator />
        </ComboboxViewport>

        <ComboboxArrow />
      </ComboboxContent>
    </ComboboxPortal>
  </ComboboxRoot>
</template>

๐Ÿ“ธ Screenshots

๐Ÿ“ Checklist

sadeghbarati commented 1 month ago

Thanks, by the way, you can upload files without adding them to your repository

NehemiahAklil commented 1 month ago

Sorry about that I was in hurry. And I didn't think it would add that last commit to the PR only the one commit with the fix.