Adding good practises in the code of the notebooks

unpackAI / DL201

Deep learning 201

6 stars 6 forks source link

Adding good practises in the code of the notebooks #28

Open Philanoe opened 2 years ago

Philanoe commented 2 years ago

[ ] correcting the variables name
[ ] using os.path.join to create filename paths
[ ] debugging the code of 1_4 notebook to allow it to run on Windows
[ ] using a seed for each call of sample() to avoid verbose commits

Philanoe commented 2 years ago

Hi, here is another good practice I would like to write here : avoiding this kind of code: from pycaret.regression import * and replacing it by : import pycaret.regression import as py_regression

Hence, in the hundreds of following lines, we will know that setup(), create_model(), tune_model(), etc. comes from this wonderful libraries. This is a good habit for coders, and essential for the beginners to understand the origin of those functions.

jamescavanagh commented 2 years ago

Hi, this is a good idea. I agree that it can cause problems and should be rectified

jamescavanagh commented 2 years ago

However, os.path.join is outdated in favor of pathlib. Os.path.join is wordy compared to a path object which can use the / operator for better readability