search

unpackAI / unpackai

The Unpack.AI library
https://www.unpackai.com
MIT License
20 stars 4 forks source link

🏴Format output code with black #11

Open jfthuong opened 3 years ago

jfthuong commented 3 years ago

To have a nice looking code, format the output of nbdev with black (https://github.com/psf/black).

It should be automatic (Github action ... or pre-commit action ... or a build procedure that runs nbdev and black after that)

Shield:

[![Code style: black](https://img.shields.io/badge/code%20style-black-000000.svg)](https://github.com/ambv/black)
raynardj commented 3 years ago

A separate requirements.txt

Shall we put a dev directory? with a README.md inside as guidance, with a requirements.txt as installation instruction, to install things only for dev environment?

As currently its in requiement-test.txt https://github.com/unpackAI/unpackai/blob/8b934f774bc1e09cd9c7e11d1c7652f3fedf02c9/requirements-test.txt#L5-L9

jfthuong commented 3 years ago

yes, we could have a requirements-dev.txt .... on the other hand, nbdev is supporting requirements for dev in the ini file. To be explored