unplugin / unplugin-icons

🤹 Access thousands of icons as components on-demand universally.
https://www.npmjs.com/package/unplugin-icons
MIT License
3.66k stars 131 forks source link

fix: update qwik support #291

Closed michaelhthomas closed 12 months ago

michaelhthomas commented 12 months ago

Description

Qwik support for unplugin-icons was working for a brief period but is no longer working. The example project in this repo does not display an icon, and simply has an empty svg tag in place of the icon. This PR fixes the Qwik integration and makes importing icons function as expected.

Additional context

The root of this issue is that the existing compiler for Qwik was outputting pre-compiled Javascript (not JSX), but was reporting the file type as tsx. As a result, icons were being double processed, ultimately resulting in a broken component. This PR updates the Qwik compiler to output JSX, and allows the remaining transformations to be handled by the Qwik JSX compiler for better compatibility.