search

unplugin / unplugin-icons

🤹 Access thousands of icons as components on-demand universally.
https://www.npmjs.com/package/unplugin-icons
MIT License
3.65k stars 131 forks source link

feat: add Qwik JSX compiler #318

Closed userquin closed 7 months ago

userquin commented 8 months ago

This PR just adds a new option to jsx to allow use it with Qwik, no idea if the types can be shared, the example just works.

The idea is to have another "compiler" for Qwik.

PR in draft until some Qwik expert review this:

imagen

Check this SB repro with custom compiler using @svgr/core + @svgr/plugin-jsx plugin (works in SB while @svgx/core doesn't): https://stackblitz.com/edit/unplugin-unplugin-icons-p2lwmh

stackblitz[bot] commented 8 months ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Aslemammad commented 7 months ago

Maybe Jack can help also! He's an active developer in the qwik community. cc @thejackshelton

Also my mates, @AmirSa12 @araqaee can share what they know.

userquin commented 7 months ago

You can check it with this link: https://stackblitz.com/fork/github/unplugin/unplugin-icons/tree/userquin/feat-add-qwik-jsx-compiler/examples/vite-qwik

Since we don't have yet the new option in jsx TS complains in vite.config.ts...