unplugin / unplugin-icons

🤹 Access thousands of icons as components on-demand universally.
https://www.npmjs.com/package/unplugin-icons
MIT License
4.13k stars 144 forks source link

fix: Svelte runes detection not working correctly in monorepos #382

Closed hmnd closed 1 month ago

hmnd commented 1 month ago

Description

347 introduced support for Svelte 5 runes. In doing so, the Svelte plugin now imports from svelte/compiler. Without svelte being listed as an optional peer dependency, the import did not correctly resolve svelte from the current workspace within a monorepo. Thus, if another package in the monorepo depended on Svelte 5, a package depending on Svelte 4 could be misidentified as the newer version.

stackblitz[bot] commented 1 month ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

userquin commented 1 month ago

/cc @benmccann @dominikg

userquin commented 1 month ago

@hmnd @benmccann to release this we also need this another PR #381 and switch types/svelte to types/svelte5 adding the corresponding subpacka exports.