unplugin / unplugin-vue

✨ Transform Vue 3 SFC to JavaScript. Supports Vite, esbuild, Rollup, Webpack and more.
MIT License
175 stars 7 forks source link

when using unplugin-vue/esbuild, an error will occur if there is no dependency on Vite. #155

Closed zzfn closed 8 months ago

zzfn commented 8 months ago

Describe the bug

CleanShot 2024-03-10 at 00 44 01@2x

Reproduction

https://github.com/element-plus/element-plus-icons.git

System Info

System:
    OS: macOS 13.4.1
    CPU: (8) arm64 Apple M1 Pro
    Memory: 79.22 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.10.0 - /opt/homebrew/opt/node@20/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 10.2.3 - /opt/homebrew/opt/node@20/bin/npm
    pnpm: 8.15.4 - /opt/homebrew/bin/pnpm
  Browsers:
    Chrome: 122.0.6261.112
    Chrome Canary: 124.0.6347.0
    Edge: 122.0.2365.80
    Safari: 16.5.1

Used Package Manager

pnpm

Validations

sxzz commented 8 months ago

Cannot reproduce. Try to remove node_modules and re-install again.

sxzz commented 8 months ago

The latest CI is passed. Please refer to https://github.com/element-plus/element-plus-icons/blob/main/.github/workflows/unit-test.yml for usage

zzfn commented 8 months ago

i'm sorry, I didn't make it clear i encountered this issue while using esbuild separately. the steps to reproduce can deleting the "playground" folder. i thinking is that vite, a dependency of "playground" is being detected, which is why no errors are being reported. @sxzz

sxzz commented 8 months ago

Please provide a minimal reproduction to reopen the issue. Thanks.

Why reproduction is required

zzfn commented 8 months ago

Please provide a minimal reproduction to reopen the issue. Thanks.

Why reproduction is required

it is reproduction (github issue only the comment button)

sxzz commented 8 months ago

Thanks for your feedback! Fixed & Released as 5.0.5