unpoller / helm-chart

Helm chart for deploying unpoller on kubernetes
3 stars 2 forks source link

Charts with "+" on tags generates package, don't update index. #4

Open jlpedrosa opened 6 months ago

jlpedrosa commented 6 months ago

Created an issue in chart-releaser https://github.com/helm/chart-releaser-action/issues/193 to see if they have any insights.

If we don't get this sorted quikcly I'll update the index.yaml manually.

jlpedrosa commented 6 months ago

KMN, it turns out that chart releaser is making a mess with the download URLs, I created a PR to fix it. https://github.com/helm/chart-releaser/pull/406

jlpedrosa commented 6 months ago

Ok, while the + token is the most used on charts.

Build metadata MAY be denoted by appending a plus sign and a series of dot separated identifiers immediately following the patch or pre-release version. 
Identifiers MUST comprise only ASCII alphanumerics and hyphens [0-9A-Za-z-]. 
Identifiers MUST NOT be empty. 
Build metadata MUST be ignored when determining version precedence.
Thus two versions that differ only in the build metadata, have the same precedence. Examples: 1.0.0-alpha+001, 1.0.0+20130313144700, 1.0.0-beta+exp.sha.5114f85, 1.0.0+21AF26D3----117B344092BD.

we can use the - for hot patches, not super happy about it, but I don't think helm people will be quick. In theory that inidicates not stable version (pre-rel). I am not positive if renovate/dependabot will help repos referencing the chart.

github-actions[bot] commented 5 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.