unpreset / unocss-preset-theme

The dynamic theme presets for UnoCSS.
https://unocss-preset-theme.todev.cc
119 stars 11 forks source link

v0.9.0 generates wrong CSS #57

Closed ModyQyW closed 11 months ago

ModyQyW commented 11 months ago

https://unocss.dev/play/?html=DwEwlgbgBAxgNgQwM5ILwCIAuBTAHpgWgAcAnMAWwRIE90A%2BAKGAHpwI6g&config=JYWwDg9gTgLgBAbwFBzgEwKYDNgDsMDCEuOA5gDQpxhQYDOGMAqrhJQL5xZQQhwDkAV1YBjOnX5JQkWImq0GMACoALDCAxxO3XgOEQxdALQ16jIzDUbJSDAA8Z8TFgCGggDZPseQsTIAKZFRTRToALjgAbSpghUYWCH8ASkpUWLNlKwxAmLTLdQwIoLSS92BSFRgi3JLUEQh3aHDEGtrY0BcoAE8I-gA3Tv8jIwx3I3rGqBMoDu6kyTaS9lbUdlTFtE6Aa2rFtImm3b20mlmegQGoIZGxg6nTkE6u%2BZW05b211ve3pKoAXQ4vyAA&css=Q&options=N4XyA

image

Expected:

/* layer: theme */
:root{--un-preset-theme-colors-primary:var(--el-color-primary);}
.dark{--un-preset-theme-colors-primary:var(--el-color-primary);}
/* layer: default */
.text-primary{color:var(--un-preset-theme-colors-primary);}

Or

/* layer: theme */
:root, .dark {--un-preset-theme-colors-primary:var(--el-color-primary);}
/* layer: default */
.text-primary{color:var(--un-preset-theme-colors-primary);}

Or

/* v0.8.1 behavior */
/* layer: default */
.text-primary{color:var(--el-color-primary);}

Reproduction

Dunqing commented 11 months ago

Thank you for your feedback, Yes this is a bug.

ModyQyW commented 11 months ago

@Dunqing Sorry, but I think v0.9.1 just reverted https://github.com/Dunqing/unocss-preset-theme/pull/48? Should I open another issue?

https://unocss.dev/play/?html=DwEwlgbgBAxgNgQwM5ILwCIAuBTAHpgWgAcAnMAWwRIE90A%2BAKGAHpwI6g&config=JYWwDg9gTgLgBAbwFBzgEwKYDNgDsMDCEuOA5gDQpxhQYDOGMAqrhJQL5xZQQhwDkAV1YBjOnX5JQkWImq0GMACoALDCAxxO3XgOEQxdALQ16jIzDUbJSDAA8Z8TFgCGggDZPseQsTIAKZFRTRToALjgAbSpghUYWCH8ASkpUWLNlKwxAmLTLdQwIoLSS92BSFRgi3JLUEQh3aHDEGtrY0BcoAE8I-gA3Tv8jIwx3I3rGqBMoDu6kyTaS9lbUdlTFtE6Aa2rFtImm3b20mlmegQGoIZGxg6nTkE6u%2BZW05b211ve3pKoAXQ4vyAA&css=Q&options=N4XyA

image

I think :root should go before .dark.

Dunqing commented 11 months ago

@Dunqing Sorry, but I think v0.9.1 just reverted #48? Should I open another issue?

https://unocss.dev/play/?html=DwEwlgbgBAxgNgQwM5ILwCIAuBTAHpgWgAcAnMAWwRIE90A%2BAKGAHpwI6g&config=JYWwDg9gTgLgBAbwFBzgEwKYDNgDsMDCEuOA5gDQpxhQYDOGMAqrhJQL5xZQQhwDkAV1YBjOnX5JQkWImq0GMACoALDCAxxO3XgOEQxdALQ16jIzDUbJSDAA8Z8TFgCGggDZPseQsTIAKZFRTRToALjgAbSpghUYWCH8ASkpUWLNlKwxAmLTLdQwIoLSS92BSFRgi3JLUEQh3aHDEGtrY0BcoAE8I-gA3Tv8jIwx3I3rGqBMoDu6kyTaS9lbUdlTFtE6Aa2rFtImm3b20mlmegQGoIZGxg6nTkE6u%2BZW05b211ve3pKoAXQ4vyAA&css=Q&options=N4XyA

image

I think :root should go before .dark.

I'm not sure if this makes a difference, can you test it?

ModyQyW commented 11 months ago

Ahhh you are right, it makes no difference in this case. Thanks.