[45] Updated GUID fetch logic.

unraid / usb-creator-next

The home of the Next-Gen Unraid USB Creator, a fork of the Raspberry Pi Imager

https://unraid.net/getting-started

Other

8 stars 3 forks source link

[45] Updated GUID fetch logic. #46

Closed quadraticat closed 2 months ago

quadraticat commented 3 months ago

Resolves: #45

Changes:

Updated the GUID fetch regex to take in any amount of characters, hopefully squashing the Sundisk GUID issue.

Testing:

Unable to test hardware as this laptop doesn't have a USB port, but can check early morning tomorrow (7/29)

Notes:

There seems to be an issue with code signing in the cmake, unable to build project while that section is live. Unsure if this is just a me problem, but the issue persists after multiple installs of the project.

elibosley commented 3 months ago

This looks good - but definitely get the build working and test this before we merge. Try to work with @jlre249 to get your build environment set up fully so that you can start building and testing these changes!

quadraticat commented 3 months ago

This looks good - but definitely get the build working and test this before we merge. Try to work with @jlre249 to get your build environment set up fully so that you can start building and testing these changes!

Build works and tested Sundisk USB and PNY USB. @elibosley

elibosley commented 3 months ago

Awesome! Any chance you can grab me the binaries for Mac / Windows and bump the build version to 1.0.1?

elibosley commented 2 months ago

I'd add your .DS_Store file to your gitignore and delete it, as these are basically macos placeholder files.