search

unrealities / MTGA_Draft_17Lands

Magic: The Gathering Arena draft tool that utilizes 17Lands data
MIT License
26 stars 1 forks source link

[Bug]: 3.17 is flagged as a Trojan by Windows 11 #10

Closed Phyrre56 closed 2 months ago

Phyrre56 commented 3 months ago

Describe the bug in detail

When trying to install version 3.17 either through the app itself and the update prompt or by downloading from GitHub, unpacking, and installing from the .exe - Windows 11 flags the file as containing a Trojan (Wacatac.B!ml), halts the installation, and deletes the .exe file.

This very well could be a false positive but it is consistent and prevents installation.

Steps to reproduce this bug

Attempt to install version 3.17 in Windows 11 environment

Operating System

Windows

Operating System Version

Windows 11

Run Type

Windows Executable

Python Version

No response

Debug Log Details

No response

Possible Solution (optional)

No response

FiYir commented 3 months ago

I just tried the new executable and I'm also experiencing this. I've seen this happen when the --clean argument isn't used with pyinstaller.

unrealities commented 3 months ago

Thank you. Unfortunately, I'm away from my Windows machine for the long weekend. I believe I used the command from the README on the latest build, but I may be mistaken.

unrealities commented 3 months ago

I updated the 0317 build with the build created from the build workflow code FiYir implemented. I didn't bump the version as I didn't want an old version out there with possibly malicious or perceived malicious code.

FiYir commented 3 months ago

Windows defender is fine with this new build.

@Phyrre56 did you try the new build that was attached to the 3.17 release?

unrealities commented 2 months ago

This should be handled by the new process in 3.18, and I removed the flagged 3.17 release.

Phyrre56 commented 2 months ago

Sorry I was out of town, but thank you for addressing this and I was just able to upgrade to 3.18 so the problem is indeed solved.