unrealities / MTGA_Draft_17Lands

Magic: The Gathering Arena draft tool that utilizes 17Lands data
MIT License
26 stars 1 forks source link

[Bug]: Incorrect Arena Cube Start Date #30

Closed FiYir closed 1 month ago

FiYir commented 1 month ago

Describe the bug in detail

While working on adding support for special events, I noticed that the app currently hardcodes the start date for the Arena Cubeevent. It seems that the app should be selecting a start date that's 25 days before the current end date, similar to how 17Lands handles Cube on the card data page. This is an issue because 17Lands aggregates all cube events into a single dataset, requiring users to manually adjust start and end dates to distinguish individual events. Users might not realize they need to manually change the start date.

Steps to reproduce this bug

  1. Open the temp_set_list.json file
  2. Change the start_date for the Arena Cube to 2019-1-1
  3. Open the app
  4. Go to the Add Sets window
  5. Select Arena Cube
  6. Confirm that the start date is 2019-1-1

Operating System

Windows

Operating System Version

Windows 11

Run Type

Windows Executable

Python Version

No response

Debug Log Details

No response

Possible Solution (optional)

You could introduce a substitution string, similar to{LATEST}, which would be replaced with a date X days from the current day. This substitution could take the form of a hardcoded string like {CUBESHIFT}, shifting the date by a fixed amount, or a dynamic string such as {SHIFT:-25}, allowing for adjustment based on the specified amount within the string.