unregistered / Maxel

A native download accelerator for Mac OS X.
http://maxelapp.com/
28 stars 2 forks source link

Move in Progress Download #77

Closed ibrokemypie closed 8 years ago

ibrokemypie commented 8 years ago

Move a running download to another location from within Maxel.

unregistered commented 8 years ago

I think you can use the finder for that safely since Maxel uses file bookmarks. Not as much benefit in adding tricky features that the Finder already does. If I'm wrong though it would be a bug if you can't move files mid-download.

ibrokemypie commented 8 years ago

If a download is in progress and you try moving it, wouldnt the file be locked my Maxel, making it impossible?

unregistered commented 8 years ago

Hmm, so here's what ends up happening from my experiment: Maxel opens a filehandle to the data file, which is independent of location. As such, the file continues downloading as usual, even if you move the file. However, Maxel doesn't maintain a filehandle to the progress file, so if you move a file in mid download, it won't save progress, and once the download completes, Maxel is unable to finalize the file since it doesn't have access to the parent folder.

The solution would be to maintain a filehandle to the progress file, and if it doesn't have access to the parent folder, ask the user for access.

I've also developed a feature in the past which allowed users to "Move when Done" a file. However that turned out to be tricky and I suspect it would be bug prone.

unregistered commented 8 years ago

Done for 2.1. Basically, you will be able to move mxdownload files that are in transit, and they will be finalized even if you don't have access to the new folder via a new sandbox entitlement. A side effect is that if mxdownload bundles are renamed, they will take on the new name during finalization.