search

unruly / java-8-matchers

Hamcrest Matchers for Java 8 features
MIT License
23 stars 5 forks source link

Fix StreamMatchers.equalTo() types #22

Open runeflobakk opened 4 years ago

runeflobakk commented 4 years ago

This is a small addition to #19 to fix some typing. Se discussion here https://github.com/unruly/java-8-matchers/issues/18#issuecomment-612429327

Fixes #18

CliveEvans commented 4 years ago

Looks good but we have no build status. What happened to Travis?

runeflobakk commented 4 years ago

I had to do some changes in #23 to get the Travis build to work for my fork https://travis-ci.com/github/runeflobakk/java-8-matchers

Build on Travis on OpenJDK 8 (rationale in commit message) https://github.com/unruly/java-8-matchers/pull/23/commits/1070dd7ea5f90eda9f0e3b5a7ea9e82168ab3ae6

Other changes in .travis.yml

bruceeddy commented 4 years ago

Hi Clive, Rune,

I hope to make some time today or tomorrow to follow up There are some policy changes at Unruly which mean I'd like to add non-Unruly employees to the committer/releaser group. I'd like you thoughts on suitable candidates

--bruce

On Wed, 13 May 2020, 09:11 CliveEvans, notifications@github.com wrote:

Looks good but we have no build status. What happened to Travis?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/unruly/java-8-matchers/pull/22#issuecomment-627824295, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPBBC5U22EUB3MDTAQ7ON3RRJI3XANCNFSM4MGBBHFA .

runeflobakk commented 4 years ago

Great! I have no shame, so I am nominating myself 😅

CliveEvans commented 4 years ago

I'm happy to come back on board ;-)

CliveEvans commented 4 years ago

I had to do some changes in #23 to get the Travis build to work for my fork https://travis-ci.com/github/runeflobakk/java-8-matchers

Ok, let's get that one in first then.

looks meaningfully at @bruceeddy