search

unruthless / jQuery.cardcheck

Credit card type detection and validation
11 stars 4 forks source link

More card types and *slightly* more accurate checking #6

Closed leek closed 13 years ago

leek commented 13 years ago
unruthless commented 13 years ago

Hey Chris, thanks for the pull request! Happy to merge it in if you can do two small things:

  1. Add a test to cover the JCB card, and another to cover Diners Club. You'll want to add these two tests to /test/index.html - use the existing tests as a guide, and let me know if you need a hand writing them.
  2. For the minified version, I've been using Google's Closure Compiler with the Simple Optimization option: http://closure-compiler.appspot.com/home. Would you mind re-generating jquery.cardcheck.min.js using that service and setting?

Thanks again!

leek commented 13 years ago

Ruthie,

I've made the required edits along with a couple other minor updates.

Thanks!

leek commented 13 years ago

First time using the Github pull request feature, I actually only wanted the tests and code submitted, rather than the others. Let's try this again...