search

unsetbit / p

Peer-to-peer networking with browsers
http://unsetbit.com/p
Other
411 stars 27 forks source link

SCTP data channels #10

Closed Nuwanda closed 9 years ago

Nuwanda commented 9 years ago

Since I was having trouble with the limitations of rtp data channels, which P creates by default, I've stopped using that default and tried to create SCTP data channels instead. Unfortunately since that change no messages are delivered between peers, no errors are reported either. If I change the library to remove the default RTP option, your examples don't work either. Do you see any reason why this might be happening?

unsetbit commented 9 years ago

Thanks Pedro, could you provide a snippet of code for me to reproduce the problem? I'm guessing this is just due to the divergence of the native code since I had written P (which was 10 months ago, and the standard and implementation have changed since then). If it's a quick fix, I'll be able to submit a patch in a few days, if it's a larger architectural change, it may take a week or two.

Nuwanda commented 9 years ago

It's my understanding that simply removing the "RtpDataChannels: true" option from the object "DEFAULT_MEDIA_CONSTRAINTS" in WebRtcConnection.js should suffice as SCTP is now the default. I've also tried changing the options map in rtcConnection.createDataChannel (in the same file) to {reliable: true}, with no success (which was expected from the documentation I've found on the subject).

unsetbit commented 9 years ago

Closing this since the latest update makes data channels reliable by default.