search

unshiftio / url-parse

Small footprint URL parser that works seamlessly across Node.js and browser environments.
http://unshift.io
MIT License
1.03k stars 103 forks source link

library not compatible with URL of nodejs and browser #184

Closed adityapatadia closed 4 years ago

adityapatadia commented 4 years ago

This library is not compatible with NodeJS URL module and browser URL() module. For example, this module requires invocation of set method for certain variables. It also uses query instead of search used by native implementations.

Ideally this module should fallback to native methods if they are available and only use custom parsing when it's required.

I am ready to revamp this and create a PR is author agrees to merge it.

lpinca commented 4 years ago

It was designed to be compatible with the Node.js legacy URL parser not the WHATWG URL.

adityapatadia commented 4 years ago

Okay then may be I will fork it and make it compatible with WHATWG parser. My use case is to use it as fallback for old browsers.

Regards, Aditya Patadia

On 28-Oct-2019, at 12:14 PM, Luigi Pinca notifications@github.com wrote:

 It was designed to be compatible with the Node.js legacy URL parser not the WHATWG URL.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

adityapatadia commented 4 years ago

It's little surprising that this library is built with client side in mind and yet supports old NodeJS parser syntax.