Query params with the same name should be returned as an array

[Flackus]

Version

1.5.1

Test

const parse = require('url-parse');
console.log(parse("https://example.com/?token=1&token=2", true));

Current result:

{
  slashes: true,
  protocol: 'https:',
  hash: '',
  query: { token: '1' },
  pathname: '/',
  auth: '',
  host: 'example.com',
  port: '',
  hostname: 'example.com',
  password: '',
  username: '',
  origin: 'https://example.com',
  href: 'https://example.com/?token=1'
}

Expected result:

{
  slashes: true,
  protocol: 'https:',
  hash: '',
  query: { token: ['1', '2'] },
  pathname: '/',
  auth: '',
  host: 'example.com',
  port: '',
  hostname: 'example.com',
  password: '',
  username: '',
  origin: 'https://example.com',
  href: 'https://example.com/?token=1&token=2'
}

[lpinca]

This is expected. See https://github.com/unshiftio/querystringify/issues/32, https://github.com/unshiftio/querystringify/issues/23, and https://github.com/unshiftio/querystringify/issues/15.

You can use a custom query string parser if you want. See https://github.com/unshiftio/url-parse#usage.

[lpinca]

I'm closing this as answered. Discussion can continue if needed.

[Flackus]

Thanks for the explanation! :)