search

unsky / Deformable-ConvNets-caffe

Deformable Convolutional Networks on caffe
160 stars 83 forks source link

Problem about the code. #31

Open niuchuangnn opened 5 years ago

niuchuangnn commented 5 years ago

https://github.com/unsky/Deformable-ConvNets-caffe/blob/e0f7abd58e166398d3695871769108f03e547786/deformable_conv_cxx/deformable_im2col.cu#L395 Should be int num_kernels = height_col * width_col * 2 * kernel_h * kernel_w * deformable_group;?

niuchuangnn commented 5 years ago

https://github.com/unsky/Deformable-ConvNets-caffe/blob/e0f7abd58e166398d3695871769108f03e547786/deformable_conv_cxx/deformable_conv_layer.cu#L106 Should be this->conv_in_channels_,this->conv_input_shape_.cpu_data()[1],this->conv_input_shape_.cpu_data()[2],this->col_buffer_.count(0), ?

niuchuangnn commented 5 years ago

Hi, @unsky, there may be some bugs in your code. Could you spend a few minutes to check that https://github.com/unsky/Deformable-ConvNets-caffe/issues/31#issuecomment-450848046. Thank you.

niuchuangnn commented 5 years ago

https://github.com/unsky/Deformable-ConvNets-caffe/blob/e0f7abd58e166398d3695871769108f03e547786/deformable_conv_cxx/deformable_conv_layer.cu#L109 Should be bottom_diff+ n*this->bottom_dim_?

unsky commented 5 years ago

时间过去太久了，有些细节可能有些问题，可能没考虑更多的边界问题，但细节忘光了，工作比较忙，你可以尝试自己做实验，看看在实验上的效果，如果有兴趣可以帮我提个pr,感谢。我目前对这份代码只能保证这份code可以跑出readme上的效果。

niuchuangnn commented 5 years ago

@unsky 谢谢您的回复。