search

unslothai / unsloth

Finetune Llama 3.2, Mistral, Phi, Qwen 2.5 & Gemma LLMs 2-5x faster with 80% less memory
https://unsloth.ai
Apache License 2.0
18.59k stars 1.3k forks source link

save_to_gguf doesn't work with absolute paths #1118

Closed giuliabaldini closed 1 month ago

giuliabaldini commented 1 month ago

Hi there,

thank you for the absolutely amazing package!

I have encountered an error when saving to gguf.

In this line you build the path for the final save, but if the path is absolute, this causes convert-hf-to-gguf.py to not find it and throw an error.

I am happy to write a PR to fix this, the best way is probably to use pathlib internally.

Best, Giulia

danielhanchen commented 1 month ago

Oh thanks for the quick fix as well!!

danielhanchen commented 1 month ago

Merged and thank you!