search

unsoluble / smalltime

A small FoundryVTT module for displaying and controlling the current time of day.
MIT License
23 stars 15 forks source link

Window position conflicts with Breaktime Module. #139

Closed BlackSwampDM closed 1 year ago

BlackSwampDM commented 1 year ago

Love the module, I also use the Breaktime module which adds a Breaktime option to the players bar. This makes the player bar larger. With your window in a fixed position relative to the height of the unmodified player window, it now obscures part of your modules window. Any luck getting a window position option? Thanks Screenshot (2) .

BlackSwampDM commented 1 year ago

I was able to disable breaktime module then move your module then re-enable so, no worries mate. Nevermind. Thanks for a gretat Mod!

unsoluble commented 1 year ago

Glad you sorted it out. As noted over in #137, I'm working on a way to nudge the SmallTime window away from Players for cases like this, just isn't done yet.

BlackSwampDM commented 1 year ago

Thanks for the response.

On Thu, Jul 28, 2022, 11:39 AM John Weston @.***> wrote:

Glad you sorted it out. As noted over in #137 https://github.com/unsoluble/smalltime/issues/137, I'm working on a way to nudge the SmallTime window away from Players for cases like this, just isn't done yet.

— Reply to this email directly, view it on GitHub https://github.com/unsoluble/smalltime/issues/139#issuecomment-1198322655, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXPJF3PMHHDP3BF5YGHQAGLVWKSTHANCNFSM545D7GMA . You are receiving this because you modified the open/close state.Message ID: @.***>

Aeristoka commented 1 year ago

on 1.15.4, I believe this isn't the intended behavior? image

unsoluble commented 1 year ago

Mmmm depends? If the SmallTime window was pinned to the top of the Players list, then no it shouldn't do that (but I can't reproduce here). If it was manually placed, it could happen.

Aeristoka commented 1 year ago

Mmmm depends? If the SmallTime window was pinned to the top of the Players list, then no it shouldn't do that (but I can't reproduce here). If it was manually placed, it could happen.

Was snapped to the top of the player list, had all players exit, snapped it to top again, the moment they started loading in (as you can see, I have 7 of them) it got buried again.

Aeristoka commented 1 year ago

if I snap it to the top while they're all loaded in, I also get the drag bar buried under the player list: image

unsoluble commented 1 year ago

Yeah I can't reproduce that here no matter what I try. Maybe try a Control-F5, something might be cached?

CleanShot 2022-10-08 at 17 55 25@2x
Aeristoka commented 1 year ago

I'll fiddle with it more after session... very strange...

unsoluble commented 1 year ago

You on Foundry v9 by any chance?

Aeristoka commented 1 year ago

You on Foundry v9 by any chance?

Sure am.

unsoluble commented 1 year ago

Got it. Sorry, I haven't been taking the time to test everything thoroughly in v9 on new builds; all my attention's been on v10 lately. Should be working better in 1.15.5 (out in a sec).

Aeristoka commented 1 year ago

No worries, appreciate your work! (and your GitHub avatar, showing your disappointment in yourself whenever you commit)