unsoluble / smalltime

A small FoundryVTT module for displaying and controlling the current time of day.
MIT License
23 stars 15 forks source link

Console error when loading scene #155

Closed ghost closed 1 year ago

ghost commented 1 year ago

Good day,

I noticed this console error popping up when loading a scene.

image

It doesn't seem to actually affect the display. The position of SmallTime is maintained correctly on the scene, even during reloads of the browser. It's recent; only started happening yesterday (Saturday, 8 Oct). The day before it was fine while I was doing game prep.

This is mostly to bring it to your attention in case it's a symptom of a larger bug that may be causing problems for someone else.

Thanks!

Morgan

unsoluble commented 1 year ago

Thanks for the report! What version of SmallTime? This was an issue in 1.15.4, should be fixed in 1.15.5 (released shortly after).

ghost commented 1 year ago

It is 1.15.4. I'll try upgrading and see if that fixes it.

ghost commented 1 year ago

I no longer see the error with 1.15.5! That's the good news. The bad news (and I'm not sure it's an issue with SmallTime) is that when snapping to the player menu, it snaps properly, but if one's game has a larger number of icons in the command menu on the left, the ones that are at the bottom (just above the player menu) are rendered on top of SmallTime.

image

If I expand the player menu, the icons are properly rendered with regard to the player menu, but the rendering continues to ignore SmallTime.

image

As I said, I'm not sure if that's your issue to fix or a glitch with core Foundry, but I thought I'd let you know. Incidentally, the previous version did not properly "stick" to the player menu when docked on top of it. Was that the fix that was implemented in 1.15.5?

Thanks!

Morgan

unsoluble commented 1 year ago

Yeah I can't do anything about collisions between SmallTime and the toolbar; the solutions are to move it elsewhere, use fewer modules that add tools, find a module that changes the layout there, or get a larger screen. :)

ghost commented 1 year ago

I figured that was the case :) No worries. Thanks for the quick replies and for all the work. SmallTime is a pleasure to use. I think we can close this issue.