unsoluble / smalltime

A small FoundryVTT module for displaying and controlling the current time of day.
MIT License
25 stars 16 forks source link

Automated darkness on scenes is not working #160

Closed ctbritt closed 1 year ago

ctbritt commented 1 year ago

the automated darkness has gone wonky with the latest update, I think.

I have my seasons set in Simple Calendar. All seems to be working there. But when I have a scene with Global Illumination enabled like so:

CleanShot 2022-10-27 at 22 34 11@2x

and darkness control and moonlight adjustment enabled, the darkness of the scene starts alternating with every tick of the clock.

I have the settings in small time set to this:

CleanShot 2022-10-27 at 22 35 47@2x

As you can see, it's NOT getting the season's sunrise and sunset from Simple Calendar (which is set to 0500 - 2030 for sunrise and sunset). It's smooshing the sunrise and sunset over to the left.

And this is what it looks like when the game is unpaused and the time is allowed to run:

https://user-images.githubusercontent.com/4516034/198383056-4e2a3762-2a67-4b12-949e-16e810138465.mp4

I'm not getting any errors or warnings in the console. So, not sure what is going on....

unsoluble commented 1 year ago

How about with nothing but SmallTime and Simple Calendar enabled? All that GI config stuff is third-party.

ctbritt commented 1 year ago

yes, with just SC and ST, i get the same effect.

ctbritt commented 1 year ago

Ok. I've removed seasons from the calendar, removed any moons, and even created a new test calendar based on the gregorian (sans moon and seasons). Still getting the flashing every tick of the game clock.

ctbritt commented 1 year ago

this is with just SC and ST enabled. Nothingf else.

unsoluble commented 1 year ago

Try a new world perhaps? I haven't seen anything like this.

ctbritt commented 1 year ago

OK. Now the handles are stuck outside the window where I can drag them.

CleanShot 2022-10-27 at 22 56 41@2x
ctbritt commented 1 year ago

the moons and sons can be dragged vertically, but not horizontally.

ctbritt commented 1 year ago

ok. tried it with a new test world. It works ok. So I guess there's something wonky in the settings? how would I reset them back to zero?

unsoluble commented 1 year ago

Does it work as expected in the first world if you have the sunrise/set sync disabled?

ctbritt commented 1 year ago

yes, it seems to work just fine in the test world.

ctbritt commented 1 year ago

here are the ST settings from an export of my main foundry settings:

{
    "key": "smalltime.current-date",
    "value": "\"Flamerule 18th, 1492  DR\""
  },
  {
    "key": "smalltime.date-showing",
    "value": "true"
  },
  {
    "key": "smalltime.moon-darkness",
    "value": "true"
  },
  {
    "key": "smalltime.moon-phase",
    "value": "1"
  },
  {
    "key": "smalltime.pinned",
    "value": "false"
  },
  {
    "key": "smalltime.player-visibility-default",
    "value": "\"2\""
  },
  {
    "key": "smalltime.position",
    "value": "{\"top\":680,\"left\":535}"
  },
  {
    "key": "smalltime.small-step",
    "value": "5"
  },
  {
    "key": "smalltime.sun-sync",
    "value": "true"
  },
  {
    "key": "smalltime.sunrise-end",
    "value": "0"
  },
  {
    "key": "smalltime.sunrise-start",
    "value": "-120"
  },
  {
    "key": "smalltime.sunset-end",
    "value": "120"
  },
  {
    "key": "smalltime.sunset-start",
    "value": "0"
  },
unsoluble commented 1 year ago

If it works as expected with the SC sync disabled, then it's most likely that there's something weird going on with your rise/set times as set in SC (or your other date/time stuff over there is nonstandard in some way I don't support).

ctbritt commented 1 year ago

In the original world (with the issue) it has the same problem whether SC sync is turned on or not.

unsoluble commented 1 year ago

Is it the same with SC disabled?