unsoluble / smalltime

A small FoundryVTT module for displaying and controlling the current time of day.
MIT License
23 stars 15 forks source link

Moon phase adjust needs a look #171

Closed unsoluble closed 11 months ago

unsoluble commented 1 year ago

From @dirusulixes#6754: Sorry, maybe I'm missing something but for me the interaction between moon phase effect on darkness in smalltime only works as expected when the max darkness level in the setting is set to its maximum (the moon slider all the way down). With that configuration new moon nights are very dark and full moon nights much less so (the 0.4 factor in the code). However when the max darkness setting is not maxed out, I would expect relatively less dark nights across all moon phases, and that is not what I get.

unsoluble commented 11 months ago

Dug into this a bunch, can't repro.