search

unsoluble / smalltime

A small FoundryVTT module for displaying and controlling the current time of day.
MIT License
25 stars 16 forks source link

[FEATURE] Make Min/Max Darkness Settings Available #197

Closed Larkinabout closed 8 months ago

Larkinabout commented 8 months ago

Please could the Min and Max Darkness settings be made available for easy changing. I had an issue where the Darkness Level would only go to 0.3 at midday in a particular world and it was because the Min Darkness had been set, I think, based on where the Darkness Level was set when I first enabled the module. Making the settings visible and editable would have allowed me to figure out and rectify the issue sooner. Many thanks.

unsoluble commented 8 months ago

Hi there! This has been a feature in SmallTime's settings for a number of years -- see the readme for details. :)

Afraid I'm not going to extend this to a per-scene setting, as that would involve major UI changes.

Larkinabout commented 8 months ago

Ah, yep, I scrolled back and forth past that numerous times, it's because of the fancy interface when my brain was expecting a box with a number in it!

Would you potentially accept the per-scene implementation as a pull request (assuming I found the time)?

unsoluble commented 8 months ago

Thanks for the offer, but it's hard to imagine that I would. As-is things are already up against my sense of how simple this ought to be.