[FEATURE REQUEST] implement new Simple Calendar options Trough API

unsoluble / smalltime

A small FoundryVTT module for displaying and controlling the current time of day.

MIT License

24 stars 15 forks source link

[FEATURE REQUEST] implement new Simple Calendar options Trough API #59

Closed mech-tools closed 3 years ago

mech-tools commented 3 years ago

Hello,

SimpleCalendar just updated its API with more data.

It would be very nice if smalltime could handle this new set of data:

Year prefix: display before year with space (if not null or empty)
Year postfix: display after year with space (if not null or empty)
Season: display somewhere near the date (if not null or empty)
Season object also returns a color code: might be cool to have that somewhere in smalltime as well.
Show the weekday heading: if false, smalltime shouldn't display the weekdays (monday, tuesday, etc..), and remove the comma before the date/month

Thx!

unsoluble commented 3 years ago

Thanks for the heads-up. The way the date-display stuff is currently designed, I need to have the same formatting options available to all calendar providers; giving bespoke options for SC would take a bit of a refactor here. Will consider it tho. :)

mech-tools commented 3 years ago

@unsoluble I believe that SimpleCalendar updated its API to fix a bug regarding days offset. The new property to display the day number is "dayDisplay".

Reason: this bug fix on SimpleCalendar repo: https://github.com/vigoren/foundryvtt-simple-calendar/issues/145

mech-tools commented 3 years ago

@unsoluble attempting to solve that issue while keeping things simple: https://github.com/unsoluble/smalltime/pull/62 Either others calendars provide the data or the relevant piece of data is not displayed.

Should be compatible with all others calendars. And can handle others calendars same piece of data if needed.