unsoluble / smalltime

A small FoundryVTT module for displaying and controlling the current time of day.
MIT License
24 stars 15 forks source link

When 'show seconds' is enabled, seconds count downwards from 59 to 00 instead of expected behavior of counting upwards. #97

Closed TheChronoMaster closed 2 years ago

TheChronoMaster commented 2 years ago

Using PF2e, Simple Calendar, SmallTime, no other time mods. Calendar provider is set to 'Simple Calendar'. Whether clock is set to 24h or 12h, as long as 'show seconds' is enabled, and time is progressing in real time, the seconds count in reverse. Minutes and hours advance as normal despite this behavior.

unsoluble commented 2 years ago

Ah. Bloody weird PF2E clock stuff strikes again — this'd be because you're set to a date that's prior to the world-start epoch for your world (so it's acting like BCE and counting down toward zero). I'll see what I can do about accounting for this, but will probably be a few days before I can get to it.

TheChronoMaster commented 2 years ago

Interesting, because my date is set well after the world-start epoch (by several years), and it does SEEM to properly count minutes and hours upwards - actually, if I compare its clock to PF2e's/Simple Calendar's world clock, Smalltime always shows 1 minute ahead, although seconds tick at the same rate (with smalltime's ticking downwards and the other ticking up), and minutes advance at the same rate - but it always displays 1 minute ahead. (IE, 1:30 vs 1:29)

unsoluble commented 2 years ago

So the minute-off thing is an interaction with Simple Calendar that I haven't sorted out yet.

The hours/minutes count up correctly because they're using a different mechanism from the seconds (for reasons).

Are you sure your date is after your world start epoch? (not the PF2 canonical start date, but the date you get in that specific world when resetting the clock)

TheChronoMaster commented 2 years ago

Okay, I think you are correct - the world's start date is always set to the exact equivalent time as when the world is first created IRL (Meaning current date, +2700 years, changing the names of months and days - in my case, this is Rova 11, 4721 AR, as opposed to the date I had set for the game, Lamashan in 4719). Even if 'current year' is set to something else in Simple Calendar, this appears to be the case.

From a practical perspective, I don't think this really affects much for my purposes, but it does seem very strange that it is calculated based on when I created the game world, rather than what I have the game world's time and year 0 set to. I can't find anywhere I would edit this either, but obviously that isn't your responsibility.

unsoluble commented 2 years ago

Go ask your (lovely, but weird af) PF2E devs about why they do the things they do. :D

unsoluble commented 2 years ago

Fixed in 1.13.15