unsplash / comment-on-pr

A GitHub Action to comment on the relevant open PR when a commit is pushed.
MIT License
150 stars 84 forks source link

Feature request: Attaching image to comment #19

Closed ErikBjare closed 4 years ago

ErikBjare commented 4 years ago

First things first: Nice work on this action, looks great!

I'm building a web application (https://github.com/ActivityWatch/aw-webui) and we take screenshots in our e2e testing that I'd like to show as a comment of each PR. Kinda like how some code coverage services do with their coverage maps.

tl;dr: Is there any way to attach images to the comments? That would be truly awesome.

ErikBjare commented 4 years ago

It appears that the GitHub API doesn't support uploading images and therefore neither can Octokit (https://github.com/octokit/octokit.rb/issues/986), so I guess I'd need to upload them somewhere and then simply attach them with markdown. I was hoping there would be an easier one-step way, but apparently not.

Closing since it's unlikely this will happen. Thanks again for your work on this :)