search

unsplash / comment-on-pr

A GitHub Action to comment on the relevant open PR when a commit is pushed.
MIT License
150 stars 84 forks source link

Feature request: add support for pull_request_target #28

Closed rachelleahklein closed 4 years ago

rachelleahklein commented 4 years ago

It would be lovely if we could trigger comments on pull requests from forks using the newly minted pull_request_target workflow event. Please let us know if you plan to add this functionality. Thank you!

mikehardy commented 4 years ago

Other actions that fail on fork-based workflows are simply able to move immediately to pull_request_target without further action needed (other than documentation), for example

https://github.com/amannn/action-semantic-pull-request/pull/25/files

https://github.com/amannn/action-semantic-pull-request/pull/24/files

(the implied question being - shouldn't this be the same? Or is there something specific about this action that ties it to pull_request ?)

rachelleahklein commented 4 years ago

You're right; on further reflection pull_request still meets our needs as well.

Thank you!