search

unsplash / intlc

Compile ICU messages into code. Supports TypeScript and JSX. No runtime.
MIT License
56 stars 3 forks source link

Escape JS string backticks #92

Closed samhh closed 2 years ago

samhh commented 2 years ago

Closes #82, depends #91 (to avoid conflicts).

Note that master now always uses backticks, so issues with escaping single quotes in the current release now manifest as issues with escaping backticks.

I think JSX doesn't need escaping because both {} and <> are fully used (or rejected for syntax violation during parsing) for ICU itself.

OliverJAsh commented 2 years ago

so issues with escaping single quotes in the current release now manifest as issues with escaping backticks.

Should we open another issue if we're closing https://github.com/unsplash/intlc/issues/82?

samhh commented 2 years ago

Should we open another issue if we're closing https://github.com/unsplash/intlc/issues/82?

I wasn't clear.

The current release fails to escape single quotes.

Master no longer uses single quotes, so the issue has moved sideways to failing to escape backticks.

As of this PR, there should be no more issues with escaping period.