search

unsplash / unsplash-js

🤖 Official JavaScript wrapper for the Unsplash API
https://www.npmjs.com/package/unsplash-js
MIT License
2.15k stars 157 forks source link

Misc: fixes #148

Closed samijaber closed 3 years ago

samijaber commented 3 years ago

Overview

github-actions[bot] commented 3 years ago

size-limit report 📦

Path Size
dist/unsplash-js.cjs.production.min.js 3.54 KB (+34.36% 🔺)
dist/unsplash-js.esm.js 3.55 KB (+33.98% 🔺)
samijaber commented 3 years ago

^ The size increase must be tied to re-exporting the types...🤔

3.5kb is still pretty good IMO so I'm not going to lose sleep over this. I'll add a note, we can dig into bringing the size back down after merging the major version + response types.

EDIT: Ah, this is most likely explained by how large the Language enum is. Tree-shaking should allow users who don't rely on the enum to not bundle it, keeping the size closer to ~2.5kb.