search

unstoppable-domains-integrations / KyberSwap-iOS

:iphone: iOS app for KyberSwap
https://kyberswap.com
GNU General Public License v3.0
0 stars 2 forks source link

Implement .crypto domain resolution #4

Open sudoryan opened 3 years ago

sudoryan commented 3 years ago

Copy/pasting addresses is an outdated method of sending cryptocurrency and isn’t a great user experience. We should allow users the option to enter in a .crypto or .zil domain instead of an address. We’ll take the domain and resolve it to an address for them. No more copy/pasting for the user!

How to resolve a .crypto domain: .crypto domains and their records are stored on Ethereum so we read the blockchain to retrieve the address records for a domain. Learn more about Unstoppable Domains here. .zil domains work similarly but on the Zilliqa blockchain. Unstoppable Domains conveniently provides libraries in Javascript, Java, and Swift to make resolution easier.

Domain resolution should fit into the existing UI for the application. And it should happen in the address field when sending crypto.

Example of resolution: resolution-example

Steps: Get user input from address bar If a valid .crypto or .zil domain is entered, begin resolution Disable the input bar and show a pending state - “(domain) is resolving…” Resolve domain by calling library method If error occurs, show “No records found for (domain)” If successful, replace user input with resolved address and show “(domain) resolved to (address)”

Resolution Library

Swift: https://github.com/unstoppabledomains/resolution-swift

Requirements: Application must be able to resolve .crypto and .zil domain Domain resolution fits into application’s current UI Shows 3 states: Domain resolving Domain resolution error Domain resolved

Please make a PR to develop branch and include .gif of resolution.

Developer Discord: https://discord.gg/HtshAxDSEF

Where resolution should happen: resolution

gitcoinbot commented 3 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 1000.0 USD (999.7 USD @ $1.0/USD) attached to it as part of the https://github.com/unstoppable-domains-integrations fund.

gitcoinbot commented 3 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 265 years, 7 months from now. Please review their action plans below:

1) matwaller has applied to start work _(Funders only: approve worker | reject worker)_.

Hey this looks like a interesting opportunity, I'd be more than interested in discussing and taking a look at this, I can start immediately shall I join the discord channel? 2) ertunc87 has applied to start work _(Funders only: approve worker | reject worker)_.

Aklima herzaman bir fikir illaki gelir hersey cok iyi ama eksiklik dünya çapında tüm dünyaya aynı yanıtı berebilnek 3) scriptsource has applied to start work _(Funders only: approve worker | reject worker)_.

Interested, is it about resolving the domain into address? Do we need to implement complete front end. 4) loleok has applied to start work _(Funders only: approve worker | reject worker)_.

I'll add the resolution-swift library to the podfile and complete the domain resolution use case for .crypto and .zil domains. I'll provide a PR with the code and a gif demo. 5) hectorsvill has been approved to start work.

I will use SwiftUI for the UI and write a controller class to control the resolution-swift module and user input.

Learn more on the Gitcoin Issue Details page.

gitcoinbot commented 3 years ago

@hectorsvill Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

hectorsvill commented 3 years ago

Yes.

On Sat, Apr 10, 2021 at 9:16 AM Gitcoin.co Bot @.***> wrote:

@hectorsvill https://github.com/hectorsvill Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day https://gitcoin.co/issue/unstoppable-domains-integrations/KyberSwap-iOS/4/100025486?snooze=1 | 3 days https://gitcoin.co/issue/unstoppable-domains-integrations/KyberSwap-iOS/4/100025486?snooze=3 | 5 days https://gitcoin.co/issue/unstoppable-domains-integrations/KyberSwap-iOS/4/100025486?snooze=5 | 10 days https://gitcoin.co/issue/unstoppable-domains-integrations/KyberSwap-iOS/4/100025486?snooze=10 | 100 days https://gitcoin.co/issue/unstoppable-domains-integrations/KyberSwap-iOS/4/100025486?snooze=100

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/unstoppable-domains-integrations/KyberSwap-iOS/issues/4#issuecomment-817160764, or unsubscribe https://github.com/notifications/unsubscribe-auth/AELHNM5A4TZG45ZU4AB32O3TIB2ULANCNFSM42PFTUEQ .

gitcoinbot commented 3 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 1000.0 USD (999.7 USD @ $1.0/USD) has been submitted by:

sudoryan commented 3 years ago

@hectorsvill - can you send me an email to rleinbox@gmail.com? I'd like to schedule a zoom meeting to discuss this bounty.

hectorsvill commented 3 years ago

Will do.

On Mon, Apr 12, 2021 at 8:14 PM Ryan Le @.***> wrote:

@hectorsvill https://github.com/hectorsvill - can you send me an email to @.***? I'd like to schedule a zoom meeting to discuss this bounty.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/unstoppable-domains-integrations/KyberSwap-iOS/issues/4#issuecomment-818399631, or unsubscribe https://github.com/notifications/unsubscribe-auth/AELHNM23UIBIZPVARKJ2AYTTIOZKRANCNFSM42PFTUEQ .

gitcoinbot commented 3 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 1000.0 USD (999.7 USD @ $1.0/USD) attached to this issue has been cancelled by the bounty submitter