[#175715588] - Free domains minter contract for developers

unstoppabledomains / dot-crypto

Contracts and tools for .crypto

78 stars 38 forks source link

[#175715588] - Free domains minter contract for developers #39

Closed DeRain closed 3 years ago

aquiladev commented 3 years ago

I just checked our codebase and want to discuss naming patterns. The most common approach to use underscore prefix for local private variables in a contract and do not use underscore prefix for function parameters It would be good to use ubiquitous approach

aquiladev commented 3 years ago

FYI I run MythX security analysis of the contracts. There are 2 Medium issues and 1 Low

DeRain commented 3 years ago

FYI I run MythX security analysis of the contracts. There are 2 Medium issues and 1 Low

Medium issues should be fixed now.

mvlabat commented 3 years ago

Shall we drop our FreeRegistrar smart contract, since we now have this? It isn't deployed anywhere and I doubt it has any userbase.