unstoppabledomains / resolution

A library to resolve blockchain domain names.
MIT License
222 stars 66 forks source link

Add properties tokenId namehash image_url to TokenUriMetadata #250

Closed Magofoco closed 1 year ago

Magofoco commented 1 year ago

Background

The function .tokenURIMetadata returns an object of type TokenUriMetadata. This type is missing some properties: tokenId, namehash and image_url.

The current TokenUriMetadata in master does not contain tokenId, namehash and image_url. However, if you do something like:

    const myData = await resolution.tokenURIMetadata(VALID_DOMAIN); // Where VALID_DOMAIN is a registered unstoppable domain
    console.log(myData)

myData returns an object containing also tokenId, namehash and image_url.

Changes

Added the optional field tokenId, namehash and image_url in the type TokenUriMetadata

To Do

Additional Deployment and/or Rollback Steps

Code Review

This Pull Request was thoroughly reviewed and meets all Code Review Standards pertaining to:

Please select all applied standards relevant to this PR.

Confirmation

Magofoco commented 1 year ago

Sorry to bother, what do you think about this PR? @bogdan @enaqx @bonsaiben @hewigovens @sammyluo @tunguyennnnn

sammyluo commented 1 year ago

Hi @Magofoco. Sorry for the late reply. We will have a look at your PR soon.

Magofoco commented 1 year ago

@tunguyennnnn @sammyluo Thanks for this! How can I merge this PR? Should I be a maintainer?

tunguyennnnn commented 1 year ago

@tunguyennnnn @sammyluo Thanks for this! How can I merge this PR? Should I be a maintainer?

I'll merge for you! thank you!