Closed Magofoco closed 1 year ago
Sorry to bother, what do you think about this PR? @bogdan @enaqx @bonsaiben @hewigovens @sammyluo @tunguyennnnn
Hi @Magofoco. Sorry for the late reply. We will have a look at your PR soon.
@tunguyennnnn @sammyluo Thanks for this! How can I merge this PR? Should I be a maintainer?
@tunguyennnnn @sammyluo Thanks for this! How can I merge this PR? Should I be a maintainer?
I'll merge for you! thank you!
Background
The function
.tokenURIMetadata
returns an object of typeTokenUriMetadata
. This type is missing some properties:tokenId
,namehash
andimage_url
.The current
TokenUriMetadata
in master does not containtokenId
,namehash
andimage_url
. However, if you do something like:myData
returns an object containing alsotokenId
,namehash
andimage_url
.Changes
Added the optional field
tokenId
,namehash
andimage_url
in the typeTokenUriMetadata
To Do
Additional Deployment and/or Rollback Steps
Code Review
This Pull Request was thoroughly reviewed and meets all Code Review Standards pertaining to:
Please select all applied standards relevant to this PR.
Confirmation