unstructuredstudio / zubhub

Creative Education Platform
https://unstructured.studio/zubhub
GNU Affero General Public License v3.0
50 stars 165 forks source link

(feat): Improve search for non-logged-in users #1087

Closed brrkrmn closed 5 months ago

brrkrmn commented 10 months ago

Summary

This PR addresses the intended flow explained here. Now, logged-out users can search for projects and creators

Closes #802

Changes

Although this PR is to make changes for non-logged-in users, I kept some of the changes that also affect logged-in user's experience but can remove them upon your comments.

For non-logged-in users:

For logged-in users:

To Do

Screenshots

Please see how results look for different combinations here

Here is a quick demonstration of how search looks like for an unauthenticated user:

https://github.com/unstructuredstudio/zubhub/assets/92817363/b752b529-ce30-43d1-ad26-f114abca8c72

Further Improvement

There are some things to be improved for the overall search feature, which can be a part of another PR. Some of them are:

brrkrmn commented 10 months ago

Update: results not overflowing 1 row for non-logged-in users

NdibeRaymond commented 9 months ago

code looks ok but still need to test the UI with user data

NdibeRaymond commented 5 months ago

had to refactor a lot of things here (some of which are not directly related to this patch but still hurts my eyes). It's good to go now

github-actions[bot] commented 5 months ago

All pre-commit checks passed ✅✅✅