Open brrkrmn opened 10 months ago
@brrkrmn what happens if we have much more creators (maybe 10 or more)? can you attempt this and make a video so we see how the hover effect works in that case? Wondering if it will overflow or wrap. This should also be addressed in the design, was it?
needs rebase
pre-commit checks failed ❌❌❌ make sure you have pre-commit set up locally (see the README.md for instructions). If you have set up pre-commit locally, you may need to undo this commit and run "pre-commit" locally to see what the errors are.
@brrkrmn what happens if we have much more creators (maybe 10 or more)? can you attempt this and make a video so we see how the hover effect works in that case? Wondering if it will overflow or wrap. This should also be addressed in the design, was it?
It'll look like what we have for +3 creators, showing 3 circles at most and indicating the number of the remaining creators. Like this:
https://github.com/unstructuredstudio/zubhub/assets/92817363/93c61a23-7bce-4afd-b711-3ac3ee6de1ff
This will only be applicable when the 'team' feature is made available. I'm not sure how teams are going to look exactly but if they have their own avatars, we can use the name and avatar of the team instead of showing all the creators in the activity card. And then we can show all creators in detail in the team's page or activity details page. In that case, we should have a larger section for the creators to be able to show this many.
pre-commit checks failed ❌❌❌ make sure you have pre-commit set up locally (see the README.md for instructions). If you have set up pre-commit locally, you may need to undo this commit and run "pre-commit" locally to see what the errors are.
pre-commit checks failed ❌❌❌ make sure you have pre-commit set up locally (see the README.md for instructions). If you have set up pre-commit locally, you may need to undo this commit and run "pre-commit" locally to see what the errors are.
pre-commit checks failed ❌❌❌ make sure you have pre-commit set up locally (see the README.md for instructions). If you have set up pre-commit locally, you may need to undo this commit and run "pre-commit" locally to see what the errors are.
All pre-commit checks passed ✅✅✅
@tuxology this has been rebased so we can focus on testing before merging to staging
All pre-commit checks passed ✅✅✅
Summary
The activity component is redesigned according to the new proposed design .
Closes #1090
Changes
colors.js
file.Screenshots
Desktop
Mobile
Multiple Creators Demonstration
https://github.com/unstructuredstudio/zubhub/assets/92817363/8a2b6e4d-8f1e-4f57-8764-a03359b73779