unstructuredstudio / zubhub

Creative Education Platform
https://unstructured.studio/zubhub
GNU Affero General Public License v3.0
50 stars 165 forks source link

Usability & responsiveness improvements for non-functional buttons #917

Open ladyami opened 1 year ago

ladyami commented 1 year ago

Describe the bug The "Materials Used & Category " section on the project page is currently displayed as a set of buttons. However, these buttons are not clickable and do not link to any additional information about them or a section to find similar projects that used the same material or categories. This is a usability issue as users may expect the buttons to provide more details about the materials or categories.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Zubhub Website login'
  2. Click on 'Any project card'
  3. Scroll down to 'the material used '
  4. See error

Expected behavior The list should not be in Buttons

Solution:

There are two possible solutions to this issue:

-Remove the buttons and display the materials & category list as plain text. (quick fix)

-Make the buttons functional and link them to a page to find similar projects or popups with more information about the materials. This information could include the type of material, size, quantity, and more useful info. for the category a page that show list of other project in such category

Additional Notes:

-If the buttons are removed, the section heading should be changed to something more descriptive, such as "Materials and Tools" or "Required Materials."

-If the buttons are made functional, they should have a clear visual indication that they are clickable, such as color change or a hover effect.

Screenshots Screenshot (343)

mehreeee commented 1 year ago

Nice suggestions @ladyami. Personally I think the buttons should be improved to labels and shouldn’t look like clickable buttons. They should serve as visual cues used to describe and provide information about the materials used in the project.

ladyami commented 1 year ago

@mehreeee you are right, it should be improved to labels or leave them as a button and make them functional

Boluwatifey1 commented 1 year ago

Hi @ladyami I don't know if it's from my end alone but anytime I click on a card it takes me back to the login page even when I am signed in.

aqsaaqeel commented 1 year ago

I agree, we can have them look like tags with rounded borders and a sort of greyish background color to represent that they are static visual cues, what do you think @ladyami

Temabo commented 1 year ago

I think we need to decide on a particular style for tags on the platform so it's consistent across all screens. But for this page, like you said @ladyami we have to first decide if the materials used would be clickable.

Boluwatifey1 commented 1 year ago

I think we need to decide on a particular style for tags on the platform so it's consistent across all screens. But for this page, like you said @ladyami we have to first decide if the materials used would be clickable.

i don't think they need to be clickable, it should just be improved to labels

mehreeee commented 1 year ago

Hi @srish @ladyami these are my suggestions.

  1. Remove the icons to prevent any potential confusion. Instead, convert them into labels. Their purpose is to act as visual cues; the distinct colors will indicate to the user that they are non-clickable, similar to tags.

Labels1 Labels2

@Temabo @aqsaaqeel What do you think?

Mitchell377 commented 1 year ago

for easy usability it be an active button with a text link, i believe this can be worked on @ladyami

PascalAnuche commented 1 year ago

I have been trying to click on a card even when logged but still take me back to login page

yokwejuste commented 1 year ago

I have been trying to click on a card even when logged but still take me back to login page

when last did you pulled updates?

mehreeee commented 1 year ago

How can we do that @yokwejuste ?

PascalAnuche commented 1 year ago

I have been trying to click on a card even when logged but still take me back to login page

when last did you pulled updates?

How is it done?

coderatomy commented 1 year ago

Make sure in the main directory of zubhub then run; git pull origin master or just git pull

yokwejuste commented 1 year ago

How can we do that @yokwejuste ?

I mean when last did you pulled form upstream ?


git pull upstream master
DonPresh commented 1 year ago

I think we need to decide on a particular style for tags on the platform so it's consistent across all screens. But for this page, like you said @ladyami we have to first decide if the materials used would be clickable.

I actually agree with this.

ladyami commented 1 year ago

@ everyone, the best way to solve this issue is to decide which one of the solutions can be easy to implement if we Find out from the developers then we designers can now decide what to design what do you all think?

mehreeee commented 1 year ago

Okay let’s do a quick survey. If you suggest it should be clickable, react with a “👍” emoji if it shouldn’t be clickable react with a “❤️“ emoji. What do you think @ladyami @DonPresh @Temabo @aqsaaqeel @Boluwatifey1

yokwejuste commented 1 year ago

Hey @mehreeee this is great. I'll go for this: image But still left with some questions:

mehreeee commented 1 year ago

Hey @mehreeee this is great. I'll go for this: image But still left with some questions:

  • Why the choice of those colors?
  • Why not using uniform colors?
  • Any particular significance for them and what path do they take?

I used the colors to differentiate it from our secondary button. Using one color makes it look clickable like a secondary button. Since they’re visual cues and non clickable they should look different. The colors are from our style guide. 952E4638-336B-41C0-82E6-176A50E83BB2

coderatomy commented 1 year ago

The design is nice @mehreeee. Your design is great but the contrast of the letters is kinda low. It's hard to visualize. Can you maybe try to improve it a bit. More so that top section for the description. I don't know how you planning to solve that though.

DonPresh commented 1 year ago

Okay let’s do a quick survey. If you suggest it should be clickable, react with a “👍” emoji if it shouldn’t be clickable react with a “❤️“ emoji. What do you think @ladyami @DonPresh @Temabo @aqsaaqeel @Boluwatifey1

I think both could work sha. It could be a situation where it acts like tags. If you click on glue, it will show you all projects that creators used glue or etc. @mehreeee @Temabo what do you guys think?

Temabo commented 1 year ago

Okay let’s do a quick survey. If you suggest it should be clickable, react with a “👍” emoji if it shouldn’t be clickable react with a “❤️“ emoji. What do you think @ladyami @DonPresh @Temabo @aqsaaqeel @Boluwatifey1

I think both could work sha. It could be a situation where it acts like tags. If you click on glue, it will show you all projects that creators used glue or etc. @mehreeee @Temabo what do you guys think?

Yes, both suggestions work. That's why we also need the input of the devs on which would be better to implement.

Boluwatifey1 commented 1 year ago

Okay let’s do a quick survey. If you suggest it should be clickable, react with a “👍” emoji if it shouldn’t be clickable react with a “❤️“ emoji. What do you think @ladyami @DonPresh @Temabo @aqsaaqeel @Boluwatifey1

I think both could work sha. It could be a situation where it acts like tags. If you click on glue, it will show you all projects that creators used glue or etc. @mehreeee @Temabo what do you guys think?

This is actually a nice idea if the dev are willing to work with that

ladyami commented 1 year ago

Screenshot (348)_LI

This is what Non-clickable Tag look like

Temabo commented 1 year ago

Screenshot (348)_LI

This is what Non-clickable Tag look like

Yes @ladyami I think we need to update the current tag design on the platform so we can use the same one everywhere else for consistency.

ladyami commented 1 year ago

Screenshot (348)_LI This is what Non-clickable Tag look like

Yes @ladyami I think we need to update the current tag design on the platform so we can use the same one everywhere else for consistency.

That will be Great let check what the tags look like

ladyami commented 1 year ago

I have been trying to click on a card even when logged but still take me back to login page

I just face similar problem

ladyami commented 1 year ago

@Temabo This is what non click able LABEL look like Screenshot (350)_LI

mehreeee commented 1 year ago

The design is nice @mehreeee. Your design is great but the contrast of the letters is kinda low. It's hard to visualize. Can you maybe try to improve it a bit. More so that top section for the description. I don't know how you planning to solve that though.

Screenshot (43) Screenshot (44)

Thank you. Is it better now @coderatomy?

coderatomy commented 1 year ago

Better! Thanks

ladyami commented 1 year ago

The design is nice @mehreeee. Your design is great but the contrast of the letters is kinda low. It's hard to visualize. Can you maybe try to improve it a bit. More so that top section for the description. I don't know how you planning to solve that though.

Screenshot (43) Screenshot (44)

Thank you. Is it better now @coderatomy?

I think the size needs to be decrease to make them look like non labels

DonPresh commented 1 year ago

I made them smaller like tags so it doesn't look clickable. I maintained the color scheme because of contrast issues. Tags

@ladyami review

DonPresh commented 1 year ago

I'm still working on the design

ladyami commented 1 year ago

I made them smaller like tags so it doesn't look clickable. I maintained the color scheme the site has because of contrast issues.

Description @ladyami review

YES that is what I am about to design it look good

mehreeee commented 1 year ago

I still think it looks better with the colors tho, to improve visuals. Compare github labels. I have made them smaller like you said @ladyami What do you think?

Screenshot (47) Screenshot (48)

Temabo commented 1 year ago

I still think it looks better with the colors tho, to improve visuals. Compare GitHub labels. I have made them smaller like you said @ladyami What do you think?

Screenshot (47) Screenshot (48)

If we make them have different colors, they would look clickable. So if we decide that these tags would be clickable then we can use various colors, else we can just use one color for all.

DonPresh commented 1 year ago

Exactly @Temabo. Multi-colors always work best with tags. It’s equally more visually appealing. How it functions, however, makes the difference.

DonPresh commented 1 year ago

@mehreeee nice designs btw!

Temabo commented 1 year ago

I also think we are mixing it up right now, remember during project creation, the last step is to add categories which I believe would act as tags ( which can be clicked like tags on GitHub or Hashtags on Instagram), these categories would be clickable. I don't think there is a need for the "Materials Used" to be clickable. So "Category" tags can be clickable, while materials used can just be a list @ladyami @mehreeee @DonPresh What do you guys think?

mehreeee commented 1 year ago

Exactly @Temabo. Multi-colors always work best with tags. It’s equally more visually appealing. How it functions, however, makes the difference.

Alright I understand.

brrkrmn commented 1 year ago

@mehreeee, going for the label style of Github works well. Maybe reducing the line height would be better since I think they still kind of resemble buttons.

@Temabo Yes I agree. I don't think it's necessary to make materials used clickable

mehreeee commented 1 year ago

Alright guys, here's my final proposal, we make the Materials used non-clickable and a bit squared, make the categories clickable and a bit rounded, and use colors to differentiate them. @brrkrmn @ladyami What do you think?

Screenshot (66)

Screenshot (67)

Temabo commented 1 year ago

I have 3 suggestions: 1. We can make the Materials used look like non-clickable tags and give the Category coloured clickable tags

tags

2. Here are both not clickable hence same style.

tags (2)
  1. Here, the materials used can be a bullet point list or each material can simply be separated by commas. While the categories are tags. tags (1)
Temabo commented 1 year ago

Alright guys, here's my final proposal, we make the Materials used non-clickable and a bit smaller, make the categories clickable and a bit bigger, and use colors to differentiate them. @brrkrmn @ladyami What do you think?

Screenshot (49)

This looks good! @mehreeee I like the idea of adding # to the category tags!

mehreeee commented 1 year ago

Alright guys, here's my final proposal, we make the Materials used non-clickable and a bit smaller, make the categories clickable and a bit bigger, and use colors to differentiate them. @brrkrmn @ladyami What do you think? Screenshot (49)

This looks good! @mehreeee I like the idea of adding # to the category tags!

Thank you ❤️

DonPresh commented 1 year ago

I made them smaller like tags so it doesn't look clickable. I maintained the color scheme because of contrast issues. Tags

@ladyami review

Tagsssss

I thought of a possibility of listing the materials out and making the categories as labels. What do you guys think? @mehreeee @Temabo

DonPresh commented 1 year ago

I have 3 suggestions: 1. We can make the Materials used look like non-clickable tags and give the Category coloured clickable tags tags

2. Here are both not clickable hence same style. tags (2)

  1. Here, the materials used can be a bullet point list or each material can simply be separated by commas. While the categories are tags.
tags (1)

@Temabo omg. I actually thought of the possibility of your 3rd option since it's not clickable.

DonPresh commented 1 year ago

Alright guys, here's my final proposal, we make the Materials used non-clickable and a bit smaller, make the categories clickable and a bit bigger, and use colors to differentiate them. @brrkrmn @ladyami What do you think?

Screenshot (49)

@mehreeee Love.

aqsaaqeel commented 1 year ago

I have 3 suggestions: 1. We can make the Materials used look like non-clickable tags and give the Category coloured clickable tags tags

2. Here are both not clickable hence same style. tags (2)

  1. Here, the materials used can be a bullet point list or each material can simply be separated by commas. While the categories are tags.
tags (1)

I love the 1st one, this is exactly what I had in mind when I said rounded tags. And since there are always going to be max 3 categories, having them colored makes sense.

Boluwatifey1 commented 1 year ago

I have been trying to click on a card even when logged but still take me back to login page

I just face similar problem

I haven’t been able to access this page we have been deliberating on but from the screenshots I get the problem