search

unt-libraries / catalog-api

A Django project that lets you build and expose a REST API for your library's Sierra ILS-based catalog
BSD 3-Clause "New" or "Revised" License
17 stars 8 forks source link

Fix AllToSolr exporter misnamed variables #18

Closed jthomale closed 8 years ago

jthomale commented 8 years ago

Extremely simple change. Two variables in export.batch_exporters.AllToSolr methods were misnamed (export_name), causing Django to throw an error when running the export. Fixes issue #15.

jthomale commented 8 years ago

@vphill @damonkelley @somexpert @jason-ellis @ldko Feel free to take a look; I know it's a stupid small change, but am trying to get some semblance of a workflow so I don't have to think about it each time.

somexpert commented 8 years ago

It looks like both renames are for an identical variable in both situations. Can we use either p_name or process_name for both?

jthomale commented 8 years ago

Ha--yeah looking at both of those blocks, I have totally inconsistent variable names between the two, where they are variables for identical things. I must have been trying to fit stuff in the 80 columns and just abbreviated different ways. I'll clean that up. Good catch.

jthomale commented 8 years ago

@somexpert Fixed variable names in those two blocks that were inconsistent, 9e45a25.

somexpert commented 8 years ago

:thumbsup:

damonkelley commented 8 years ago

:tada: :+1:

jthomale commented 8 years ago

I rebased issue-15 locally onto master before merging, but neglected to push the issue-15 branch back to GH after the rebase--I just rebased locally, then merged with master, and then pushed master up. So the PR didn't get linked to the merge. Next time I will force push the branch to GH after the rebase so that the PR gets resolved automatically.