search

unt-libraries / catalog-api

A Django project that lets you build and expose a REST API for your library's Sierra ILS-based catalog
BSD 3-Clause "New" or "Revised" License
17 stars 8 forks source link

Enable use of redis.conf in start_servers.sh #24

Closed jthomale closed 8 years ago

jthomale commented 8 years ago

Apparently I never set up start_servers.sh to let you specify a redis.conf file. So, in development, it wasn't possible to change how Redis persists data, and the built-in defaults only save periodically. That explains why running Redis for a short time and then shutting it down caused data loss. Commit 418aba3 lets you use a REDIS_CONF_PATH environment variable to tell start_servers.sh what configuration file you want to use for Redis. Doing this and setting the appendonly yes option in redis.conf fixes the problem described in #21. If you don't set the env var, then Redis will run as before using the built-in default configuration.

This also updates the README file based on this change and adds appendonly.aof to the .gitignore, which is needed if you turn on AOF persistence in Redis as the README now recommends.

jthomale commented 8 years ago

@vphill @damonkelley @somexpert @jason-ellis @ldko Please review as you have time. Thank you!

ldko commented 8 years ago

This looks okay to me. :+1:

jthomale commented 8 years ago

@somexpert You are correct! Fixed in d034c0d.

somexpert commented 8 years ago

:thumbsup: