Fix double slash for ftp urls.

unt-libraries / django-nomination

A Django application for nominating URLs by project.

BSD 3-Clause "New" or "Revised" License

2 stars 1 forks source link

Fix double slash for ftp urls. #81

Closed ldko closed 7 years ago

ldko commented 7 years ago

This is to allow access to the metadata page for ftp URLs if the web server strips the double slash from the URL being looked up. Created an issue about further supporting ftp URLs.

ldko commented 7 years ago

@somexpert @vphill small PR for review

somexpert commented 7 years ago

LGTM :thumbsup:

somexpert commented 7 years ago

Wait, hold that thought. What about the url reconstruction when the scheme was https or ftps?

ldko commented 7 years ago

We don't retain the "https" in the URLs, changing them all to "http", historically (which I think we should change). For this function, it would make sense just to retain the full scheme ("s" or not) as you imply, so I will change that.

somexpert commented 7 years ago

:thumbsup: