search

unt-libraries / django-nomination

A Django application for nominating URLs by project.
BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

Py2to3 #98

Closed madhuBayy closed 4 years ago

madhuBayy commented 4 years ago

@ldko @somexpert Upgraded django-nomintion to python3. In this upgrade I have changed the base image in Dockerfile as the existing one was using python 2 image. And the other changes are mostly changing unicode to str, import errors. Please review the code.

ldko commented 4 years ago

I am wondering if you double checked the changes that are in the commit that has a message of "Changes induced by 2to3 automatically"? Like the list() and str() calls that are added? Are those all really needed? For example I see this in the changeset: str('The date you entered is outside the allowed range.'), but my thought on it is that the value is already a str, so do we need that call?

madhuBayy commented 4 years ago

It looks like str() calls are not required. I'll double check through out the code for such conversions and fix them.

ldko commented 4 years ago

Ok, thanks! I think anytime we use a converter tool like 2to3 we should have a next step of checking that the automated changes are needed. Though 2to3 makes the code valid in Python 3, we won't always need everything done.