unt-libraries / warc-metadata-sidecar

BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

clearer variable name for warc_file_path? #16

Closed vphill closed 1 year ago

vphill commented 1 year ago

Not a huge issue but would it might be helpful in future debugging if we renamed the variable warc_file_path to meta_file_path to remove confusion about the warc_file (input file) and the meta_file (output file). Currently we use warc _file and then warc_file_path for different things.

https://github.com/unt-libraries/warc-metadata-sidecar/blob/bed3821d270764eec3fb3ac48c56ceac77ff06ae/warc_metadata_sidecar.py#L177