search

unt-libraries / warc-metadata-sidecar

BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Caching results and adding a return #20

Closed gracieflores closed 1 year ago

gracieflores commented 1 year ago

This should close #17 and close #14. For the 1st issue, we are creating a cache dictionary to save some time on creating the metadata (string_payload) for a record. You will notice the difference if you have a WARC file with several digest hashes that are the same. The time it takes to complete the process is reduced. For the 2nd issue, we are adding a return to the metadata_sidecar method. I added some assertions to the tests for these changes.

gracieflores commented 1 year ago

@ldko @somexpert This is ready for review.