Closed ollytom closed 3 months ago
Remaining parts of our package using integer literals instead of named constant segmentation descriptor types are at:
scte35_test.go:148: Type: 33,
scte35_test.go:161: Type: 48,
The values are documented in SCTE 35 section SCTE 35 section 10.3.3.1. Right now we have magic values floating around. See in particular:
These should be constants named, for example, ProviderAdStart or so.