untangledco / streaming

Media streaming and broadcast systems in Go
https://twitch.tv/untangledco
ISC License
96 stars 6 forks source link

m3u8: import Apple's test samples #31

Open ollytom opened 3 months ago

ollytom commented 3 months ago

Apple - you know, the one who basically "own" the HLS spec - provide some m3u8 samples at https://developer.apple.com/streaming/examples/

These would be good to have in testdata. I saw that Shaka Player have the examples in their test suite.

jacobhitchins commented 3 months ago

Would this be in addition to or replacing the current samples?

ollytom commented 2 months ago

Would this be in addition to or replacing the current samples?

In addition to. Looking at the playlists in the testdata directory each one seems to be there to test different tags. But it's not clear looking at the files what each one is really for. A comment at the top of each file, and/or a descriptive file name would be helpful especially for someone forgetful like me :)

ollytom commented 2 months ago

But it's not clear looking at the files what each one is really for.

Actually, looking at it again today, after a sleepy Sunday, I think it's relatively clear what each is for. For example, testdata/frame_rate.m3u8 is for frame rates, with names for each (PAL, NTSC etc.) and testdata/resolution.m3u8 is for resolution. There's two which are unclear:

I've fixed these up in 7c79b05479.