search

unterstein / binance-trader

Experimental trading bot for crypto currency on Binance.com
Apache License 2.0
274 stars 144 forks source link

Extend Panic Sell? #13

Open rickdeaconx opened 6 years ago

rickdeaconx commented 6 years ago

Running the docker image, whenever a buy occurs, it basically has 10 seconds to fill the sell order, if it doesn't, it panic sells.

I get WHY it does that but it would be great to be able to configure it to wait longer or wait-until-sold.

kfiresmith commented 6 years ago

Yikes, I've just watched this bot make a few terrible decisions. I do not understand the logic behind only holding a buy for 10 seconds before market-selling at a guaranteed loss.

kfiresmith commented 6 years ago

It seems like the lifespan of any single exchange action is 10 seconds, and if it can't fill an order in 10 seconds, it cancels. But from watching this on the exchange, if it would keep that order open for perhaps 30 seconds, it would be a lot more successful.

After it makes a successful purchase, it seems like it would be a lot smarter for it to just put in a stop loss percentage (user-configurable), and then hold until it hits the target profit, rather than being on a 10 second timer.

booradlee commented 6 years ago

I tried making a fork and I just can't get it to work the same. I found the panic sell counter in the code and just change that but running the code from my fork is difficult. I'm really new to github.

glennoid commented 6 years ago

The gekko trading bot uses a methodology where each time it checks and the order isn't filled, it cancels and re-places the order at the top of the order book. I think this (more aggressive strategy) would be more successful in getting orders placed in highly volatile markets, especially with other (faster and more aggressive) bots outbidding ours. Lately, only about 50% of the buy attempts have been successul. There would also need to be some logic so it doesn't keep doing this if the price is getting too high. Thoughts?