search

unterstein / binance-trader

Experimental trading bot for crypto currency on Binance.com
Apache License 2.0
274 stars 144 forks source link

RFE: Better logging, better rationale for actions #15

Open kfiresmith opened 6 years ago

kfiresmith commented 6 years ago

I'll preface this by saying that I'm not a Java guy, so I'm lodging this as a simple end-user.

So far I've had nothing but frustration from this bot because it seems to inexplicably do random things. Like randomly set a market(!?) order to panic sell all holdings at a very low rate for no explained reason :/

Suggestions:

  1. Log actions (in addition to) than the steady stream of noops that are going to stdout to a log file of some sort that can be interrogated when things go sideways for no apparent reason
  2. When taking an action, the rationale for doing so should be clear and perhaps verge on "verbose" when being logged. It's good to know why actions happen that result in losses (1).
  3. Provide an override option to have the bot not randomly panic market-sell all of your holdings upon an unknown condition, rather just exit
  4. Make the app only sell amounts that it itself has added to holdings, and leave other holdings of the same type alone. (or allow a runtime limit to be defined saying "you can only manage X amount of Y")

(1) Yes I understand losses happen in trading, yes I know when the bot gets confused it attempts to panic sell all of your holdings.