Closed gnuish closed 7 years ago
Removed commits that change the public API
There's way more happing here than the bugfix in the title. Could you split that up?
Done. Travis seems to be unable to upgrade nightly or something but it passes for stable and tests and builds fine.
I chose a different way, as I want every consume
function to roll back if parsing fails. Thanks though!
It is caused from the
self.pos = begin.pos;
right before the tags error is returned inconsume_component()
, causing the recursion to start from the beginning over and over.As of right now, that
begin.pos
is useless because the public API just usesparse_component()
(which creates a new Parser that's never re-used) andconsume_component()
is private, even thoughconsume_property()
is public.Other changes in this PR are line folding (benched 10x faster on my machine and doesn't mess Unicode chars), and minor cleanups.
If anything needs changing let me know ✌️