untitled-pit-group / foxhound

PIFS standard backend
BSD Zero Clause License
0 stars 0 forks source link

Doc: uploads.finish cannot check whether the file's SHA-1 is valid #25

Closed paulsnar closed 2 years ago

paulsnar commented 2 years ago

More of a problem of API design than anything, but uploads.finish synchronously returns an instance of File, so the SHA-1 hash might be invalid, and yet Foxhound has to assume that it's correct.

Hash mismatch can be detected as the first phase of indexing and an error set then, along with the deadline for removal, however this should imho be documented either way.